Skip to content

feat(generator-adp): Developer taking over Key-User changes #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikmace merged 38 commits into from
Jan 26, 2026
Merged

feat(generator-adp): Developer taking over Key-User changes #3967

nikmace merged 38 commits into from
Jan 26, 2026

Conversation

@nikmace
Copy link
Contributor

@nikmace nikmace commented Jan 5, 2026 •
edited
Loading

Feat for #3964.

  • Adds a new Key-User page after the Project Attributes page.
  • Enhances @sap-ux/axios-extension LREP with two additional calls for flex version, list adaptations and key-user changes for given adaptation.

@nikmace nikmace self-assigned this Jan 5, 2026
@nikmace nikmace requested review from a team as code owners January 5, 2026 16:18
@nikmace nikmace added axios-extension @sap-ux/axios-extension adp-tooling generator-adp @sap-ux/generator-adp labels Jan 5, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 1a8b6a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@sap-ux/generator-adp Minor
@sap-ux/axios-extension Patch
@sap-ux/adp-tooling Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/system-access Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/backend-proxy-middleware-cf Patch
@sap-ux/create Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sap-email-compliance
Copy link

sap-email-compliance bot commented Jan 5, 2026

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you think this is wrong or need any assistance, please contact [email protected].

lfindlaysap
lfindlaysap reviewed Jan 6, 2026
View reviewed changes
lfindlaysap
lfindlaysap requested changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, thanks for the screenshots. Here are my suggestions.

@nikmace nikmace requested a review from lfindlaysap January 7, 2026 13:52
@nikmace nikmace dismissed stale reviews from IainSAP, testojs, and lfindlaysap via e89b8ae January 19, 2026 07:56
@lfindlaysap lfindlaysap self-requested a review January 19, 2026 10:30
lfindlaysap
lfindlaysap previously approved these changes Jan 19, 2026
View reviewed changes
@nikmace
Copy link
Contributor Author

nikmace commented Jan 22, 2026

Hello @lfindlaysap, I've made some changes to the texts, can you check again? This is the commit: 45a4f11. I can send you pictures if needed.

@nikmace nikmace requested a review from lfindlaysap January 22, 2026 08:50
lfindlaysap
lfindlaysap requested changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@lfindlaysap lfindlaysap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikmace, here are my suggestions. Thanks for the screenshots :)

lfindlaysap
lfindlaysap previously approved these changes Jan 22, 2026
View reviewed changes
@nikmace nikmace requested a review from IainSAP January 22, 2026 10:47
@nikmace nikmace requested a review from lfindlaysap January 22, 2026 14:16
testojs
testojs approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 26, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

IainSAP
IainSAP approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for axios-extension.

@nikmace nikmace merged commit 0492325 into main Jan 26, 2026
16 of 17 checks passed
@nikmace nikmace deleted the feat/3964/taking-over-key-user-changes branch January 26, 2026 09:00
devinea added a commit that referenced this pull request Jan 26, 2026
@devinea
Merge remote-tracking branch 'origin/main' into add_fiori_tools_comma…
54def54 
…nds_to_index

* origin/main:
  chore: apply latest changesets
  feat(generator-adp): Developer taking over Key-User changes (#3967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hristotsolev hristotsolev hristotsolev left review comments

@testojs testojs testojs approved these changes

@IainSAP IainSAP IainSAP approved these changes

@lfindlaysap lfindlaysap lfindlaysap approved these changes

Assignees

@nikmace nikmace

Labels

adp-tooling axios-extension @sap-ux/axios-extension generator-adp @sap-ux/generator-adp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nikmace @testojs @IainSAP @hristotsolev @lfindlaysap